refactor: Don't include email addresses in export filenames - #8626
Conversation
a298f0a to
6ad24a5
Compare
j-g00da
changed the title
78983c2 to
26fbf9e
Compare
|
Do we want to include display name in the filenames? I didn't do so as this may be problematic. If we were to, it would make sense to at least somewhat sanitize these strings (at least removing slashes, backslashes, and all kinds of whitespaces). I'm not sure if we actually want it though, display name can be changed and this WILL affect ordering, which can be problematic. Since fingerprint is the actual identity, I think it should be accessible from the UI. |
It may be useful in case user exports multiple backups, but i think better not do it now, and not in this PR. Most users probably don't do any backups and having multiple devices is sufficient for backing up profiles, have not even seen any user questions about backups recently. |
Changes filenames used in the db backups and key exports, preferring fingerprint over the email address. Part of: #8572 Signed-off-by: Jagoda 艢l膮zak <jslazak@jslazak.com>
26fbf9e to
a9a5f2b
Compare
hpk42
left a comment
hpk42
left a comment
There was a problem hiding this comment.
thanks, looks good to me. and yes, we can think about normalizing displaynames and putting them into the filenames separately. Fingerprint is at least more stable than some random email address (that changes over time).
3 participants
Changes filenames used in the db backups and key exports,
preferring fingerprint over the email address.
Part of: #8572